[Refunds] Update networking layer to support multiple tax rates #14002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
added
type: task
Generated by 🚫 Danger |
hichamboushaba
force-pushed
the
issue/WOOMOB-394-refunds-networking-update
branch
from
7f1b829 to
0578165
Compare
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
force-pushed
the
issue/WOOMOB-394-refunds-networking-update
branch
from
0de75f6 to
fe84ddb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14002 +/- ##
=========================================
Coverage 38.39% 38.39%
- Complexity 9605 9606 +1
=========================================
Files 2125 2128 +3
Lines 117060 117134 +74
Branches 15030 15030
=========================================
+ Hits 44947 44979 +32
- Misses 67994 68036 +42
Partials 4119 4119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
hichamboushaba
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: WOOMOB-394
Note
I'll handle merging myself, I want to make sure that the PR doesn't violate any detekt rules in FluxC module (after this PR), but I prefer to handle this after approval given that there are other PRs that depend on this branch.
Description
This PR updates the refunding networking layer to match what the API expects about taxes: we pass an array of taxes with the the applied rate IDs. For more information check pe5sF9-4eA-p2
Steps to reproduce
There are no logic changes in this PR, for testing steps, please check the next PR #14064
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: